netdev - Re: [PATCH] Net: ethernet: eth: fix some code style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100714.182630.48510763.davem@davemloft.net>
Date:	Wed, 14 Jul 2010 18:26:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	chihau@...il.com
Cc:	eric.dumazet@...il.com, opurdila@...acom.com,
	netdev@...r.kernel.org, linux-devel@...r.kernel.org,
	mitov@...p.bas.bg
Subject: Re: [PATCH] Net: ethernet: eth: fix some code style issues

From: Chihau Chau <chihau@...il.com>
Date: Wed, 14 Jul 2010 16:22:17 -0400

> @@ -180,7 +180,8 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
>  	 *      seems to set IFF_PROMISC.
>  	 */
>  
> -	else if (1 /*dev->flags&IFF_PROMISC */ ) {
> +	/*dev->flags&IFF_PROMISC */
> +	else if (1) {

This makes the code look worse, not better.

If the commented test is in the parenthesis, it is unambiguous
which piece of code the suggested test is meant for.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html