netdev - Re: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100715.202838.258102741.davem@davemloft.net>
Date:	Thu, 15 Jul 2010 20:28:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gregory.v.rose@...el.com
Cc:	segooon@...il.com, kernel-janitors@...r.kernel.org,
	jeffrey.t.kirsher@...el.com, eric.dumazet@...il.com,
	joe@...ches.com, netdev@...r.kernel.org
Subject: Re: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow

From: "Rose, Gregory V" <gregory.v.rose@...el.com>
Date: Thu, 15 Jul 2010 11:52:54 -0700

>>-----Original Message-----
>>From: Kulikov Vasiliy [mailto:segooon@...il.com]
>>Sent: Thursday, July 15, 2010 11:46 AM
>>To: kernel-janitors@...r.kernel.org
>>Cc: David S. Miller; Kirsher, Jeffrey T; Rose, Gregory V; Eric Dumazet;
>>Joe Perches; netdev@...r.kernel.org
>>Subject: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow
>>
>>'count' is unsigned. It is initialized to zero, then it can be increased
>>multiple times, and finally it is used in such a way:
>>
>>   >>>> count--;
>>   |
>>   |    /* clear timestamp and dma mappings for remaining portion of
>>packet */
>>   |    while (count >= 0) {
>>   |            count--;
>>   |            ...
>>   ^
>>If count is zero here (so, it was never increased), we would have a very
>>long loop :)
>>
>>Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
...
> Acked By: Greg Rose <gregory.v.rose@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html