netdev - RE: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Jul 2010 11:52:54 -0700
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	Kulikov Vasiliy <segooon@...il.com>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
CC:	"David S. Miller" <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Joe Perches <joe@...ches.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow

>-----Original Message-----
>From: Kulikov Vasiliy [mailto:segooon@...il.com]
>Sent: Thursday, July 15, 2010 11:46 AM
>To: kernel-janitors@...r.kernel.org
>Cc: David S. Miller; Kirsher, Jeffrey T; Rose, Gregory V; Eric Dumazet;
>Joe Perches; netdev@...r.kernel.org
>Subject: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow
>
>'count' is unsigned. It is initialized to zero, then it can be increased
>multiple times, and finally it is used in such a way:
>
>   >>>> count--;
>   |
>   |    /* clear timestamp and dma mappings for remaining portion of
>packet */
>   |    while (count >= 0) {
>   |            count--;
>   |            ...
>   ^
>If count is zero here (so, it was never increased), we would have a very
>long loop :)
>
>Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
>---
> drivers/net/ixgbevf/ixgbevf_main.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/ixgbevf/ixgbevf_main.c
>b/drivers/net/ixgbevf/ixgbevf_main.c
>index 73f1e75..af49135 100644
>--- a/drivers/net/ixgbevf/ixgbevf_main.c
>+++ b/drivers/net/ixgbevf/ixgbevf_main.c
>@@ -2935,7 +2935,8 @@ static int ixgbevf_tx_map(struct ixgbevf_adapter
>*adapter,
> 	struct ixgbevf_tx_buffer *tx_buffer_info;
> 	unsigned int len;
> 	unsigned int total = skb->len;
>-	unsigned int offset = 0, size, count = 0;
>+	unsigned int offset = 0, size;
>+	int count = 0;
> 	unsigned int nr_frags = skb_shinfo(skb)->nr_frags;
> 	unsigned int f;
> 	int i;
>--
>1.7.0.4

Acked By: Greg Rose <gregory.v.rose@...el.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html