netdev - Re: [PATCH] netem: fix installs of dist files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100731193322.063f0fa5@nehalam>
Date:	Sat, 31 Jul 2010 19:33:22 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	stephen.hemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH] netem: fix installs of dist files

On Wed,  9 Jun 2010 20:52:09 -0400
Mike Frysinger <vapier@...too.org> wrote:

> The tc program searches LIBDIR by default for the .dist files, and that
> defaults to /usr/lib.  But the netem subdir has /lib/ hardcoded which
> means the default build+install results in the files not being found.
> 
> Further, these are plain text files which are read at runtime, so it
> doesn't make sense to give them executable bits.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> ---
>  netem/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/netem/Makefile b/netem/Makefile
> index b6ccfc6..e52e125 100644
> --- a/netem/Makefile
> +++ b/netem/Makefile
> @@ -20,9 +20,9 @@ stats: stats.c
>  	$(HOSTCC) $(CCOPTS) -I../include -o $@ $@.c -lm
>  
>  install: all
> -	mkdir -p $(DESTDIR)/lib/tc
> +	mkdir -p $(DESTDIR)$(LIBDIR)/tc
>  	for i in $(DISTDATA); \
> -	do install -m 755 $$i $(DESTDIR)/lib/tc; \
> +	do install -m 644 $$i $(DESTDIR)$(LIBDIR)/tc; \
>  	done
>  
>  clean:


Applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html