netdev - Re: ss -p is much too slow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100731193351.2b703437@nehalam>
Date:	Sat, 31 Jul 2010 19:33:51 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	David Miller <davem@...emloft.net>
Cc:	sphink@...il.com, netdev@...r.kernel.org,
	stephen.hemminger@...tta.com
Subject: Re: ss -p is much too slow

On Mon, 28 Jun 2010 16:21:39 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Steve Fink <sphink@...il.com>
> Date: Wed, 9 Jun 2010 11:42:38 -0700
> 
> > On closer inspection, it appears that ss -p does a quadratic scan. It
> > rescans every entry in /proc/*/fd/* repeatedly (once per listening
> > port? per process? I don't remember what I figured out.)
> > 
> > I humbly suggest that this is not a good idea.
> 
> Yep, this is junk.  Please give this patch a try:
> 
> ss: Avoid quadradic complexity with '-p'
> 
> Scan the process list of open sockets once, and store in a hash
> table to be used by subsequent find_user() calls.
> 
> Reported-by: Steve Fink <sphink@...il.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>

Applied


-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html