netdev - Re: [PATCH] net: add Fast Ethernet driver for PXA168.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100804071709.GK21121@mail.wantstofly.org>
Date:	Wed, 4 Aug 2010 09:17:09 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Eric Miao <eric.y.miao@...il.com>
Cc:	Sachin Sanap <ssanap@...vell.com>, netdev@...r.kernel.org,
	akarkare@...vell.com, sarnaik@...vell.com, prakity@...vell.com,
	markb@...vell.com
Subject: Re: [PATCH] net: add Fast Ethernet driver for PXA168.

On Wed, Aug 04, 2010 at 03:08:51PM +0800, Eric Miao wrote:

> And yeah we also found the driver to be very similar to mv643xx_eth
> at that time, though not sure how much it resembles. So it would be
> definitely good to have some comment why to make this a separate
> driver, instead of reusing mv643xx_eth.

As far as I can tell, the PXA168 ethernet unit was lifted from the
88E6208/6218 gateway ARM SoC (which is e.g. the SoC that is used in my
office Linksys ethernet switch, along with a Prestera), where it is
called the UniMAC.  This also explains why this thing has such extensive
address filtering capabilities, which you wouldn't expect to use in a
PXA-like application.

I'm not sure whether the Discovery/Orion GigE unit was just lifted from
that and extended to handle GigE, or that it went the other way round,
but in either case, the register sets have become too divergent to handle
them cleanly in one driver.  (I looked at this a year or so ago and found
this to be the case back then, so I'm not just saying this now to justify
the choice for two separate drivers post facto.)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html