netdev - Re: [PATCH] net: add Fast Ethernet driver for PXA168.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100804075559.GB10740@verge.net.au>
Date:	Wed, 4 Aug 2010 16:56:00 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	Sachin Sanap <ssanap@...vell.com>, netdev@...r.kernel.org,
	akarkare@...vell.com, sarnaik@...vell.com, eric.y.miao@...il.com,
	prakity@...vell.com, markb@...vell.com
Subject: Re: [PATCH] net: add Fast Ethernet driver for PXA168.

On Wed, Aug 04, 2010 at 08:58:19AM +0200, Lennert Buytenhek wrote:
> On Wed, Aug 04, 2010 at 04:17:50PM +0530, Sachin Sanap wrote:

[snip]

> > +/* smi register */
> > +#define SMI_BUSY		(1<<28)	/* 0 - Write, 1 - Read  */
> > +#define SMI_R_VALID		(1<<27)	/* 0 - Write, 1 - Read  */
> > +#define SMI_OP_W		(0<<26)	/* Write operation      */
> > +#define SMI_OP_R		(1<<26)	/* Read operation */

It was recently suggested to me that an enum be used at times like this.

> 
> (1 << 28)
> (1 << 27)
> (0 << 26)
> 
> etc (thoughout the file)

[snip]
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html