netdev - Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100805204756.GA1738@tux>
Date:	Thu, 5 Aug 2010 13:47:56 -0700
From:	"Luis R. Rodriguez" <lrodriguez@...eros.com>
To:	Julia Lawall <julia@...u.dk>
CC:	Luis Rodriguez <Luis.Rodriguez@...eros.com>,
	Jouni Malinen <Jouni.Malinen@...eros.com>,
	Sujith Manoharan <Sujith.Manoharan@...eros.com>,
	Vasanth Thiagarajan <Vasanth.Thiagarajan@...eros.com>,
	Senthilkumar Balasubramanian 
	<Senthilkumar.Balasubramanian@...eros.com>,
	"John W. Linville" <linville@...driver.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"ath9k-devel@...ts.ath9k.org" <ath9k-devel@...ts.ath9k.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing
 if indentation

On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> Outdent the code following the if.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
> 
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
> 
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
> 
> if (p1[0].column == p2[0].column):
>   cocci.print_main("branch",p1)
>   cocci.print_secs("after",p2)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

Acked-by: Luis R. Rodriguez <lrodriguez@...eros.com>

> ---
> This patch doesn't change the semantics of the code.  But it might not be
> what is intended.

Your patch is correct, it wast a tab goof, thanks for fixing this.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html