netdev - Re: [PATCH v2 1/3] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1Olbdu-0000eJ-00.xeb-mail-ru@f251.mail.ru>
Date:	Wed, 18 Aug 2010 09:56:54 +0400
From:	Dmitry Kozlov <xeb@...l.ru>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/3] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)

> Please make the following changes:
> 
> 1) Remove all of the "DEBUG" stuff.  First of all, you should never
>    TAB indent "#ifdef DEBUG" CPP checks like that, it's awfully
>    ugly and makes the code hard to read.  Next you can use
>    pr_debug() or similar for things like this.
> 
> 2) Combine all three patches into one single patch including everything.
>    There is no need to split things up like this.
> 
> Thank you.

done
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html