netdev - Re: [PATCH 1/1] ehea: Allocate stats buffer with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282140652.2194.90.camel@edumazet-laptop>
Date:	Wed, 18 Aug 2010 16:10:52 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	brking@...ux.vnet.ibm.com, ossthema@...ibm.com,
	osstklei@...ibm.com, raisch@...ibm.com, netdev@...r.kernel.org,
	Jay Vosburgh <fubar@...ibm.com>
Subject: Re: [PATCH 1/1] ehea: Allocate stats buffer with GFP_KERNEL

Le jeudi 01 juillet 2010 à 22:48 -0700, David Miller a écrit :
> From: Brian King <brking@...ux.vnet.ibm.com>
> Date: Wed, 30 Jun 2010 16:59:12 -0500
> 
> > 
> > Since ehea_get_stats calls ehea_h_query_ehea_port, which
> > can sleep, we can also sleep when allocating a page in
> > this function. This fixes some memory allocation failure
> > warnings seen under low memory conditions.
> > 
> > Signed-off-by: Brian King <brking@...ux.vnet.ibm.com>
> 
> Applied to net-next-2.6
> --

I believe there is a problem with this patch and/or bonding.

If we say ndo_get_stats() methods are allowed to sleep, then 
bond_get_stats() should be updated, because it currently calls
dev_get_stats() from a read_lock_bh(&bond->lock); section.

Are we allowed to sleep inside a read_lock_bh() ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html