netdev - Re: [PATCH] tcp: allow effective reduction of TCP's rcv-buffer via setsockopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100818.233337.52187393.davem@davemloft.net>
Date:	Wed, 18 Aug 2010 23:33:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hagen@...u.net
Cc:	netdev@...r.kernel.org, kaber@...sh.net, eric.dumazet@...il.com,
	ilpo.jarvinen@...sinki.fi
Subject: Re: [PATCH] tcp: allow effective reduction of TCP's rcv-buffer via
 setsockopt

From: Hagen Paul Pfeifer <hagen@...u.net>
Date: Sun, 15 Aug 2010 21:36:16 +0200

> +
> +		/* limit the window selection if the user enforce a smaller rx buffer */
> +		if (sk->sk_userlocks & SOCK_RCVBUF_LOCK &&
> +				(req->window_clamp > tcp_full_space(sk) || req->window_clamp == 0))
> +			req->window_clamp = tcp_full_space(sk);
> +

Logically the patch looks fine, but please fix the indentation of the
second line of the two new if() statements in this patch, the
second line's first character should line up with the character
right after the openning "(" on the previous line.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html