lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <62cfdf78ab776307fb132a5c8fde128e@localhost>
Date:	Thu, 19 Aug 2010 08:58:46 +0200
From:	Hagen Paul Pfeifer <hagen@...u.net>
To:	David Miller <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>, <kaber@...sh.net>,
	<eric.dumazet@...il.com>, <ilpo.jarvinen@...sinki.fi>
Subject: Re: [PATCH] tcp: allow effective reduction of TCP's rcv-buffer via  setsockopt


On Wed, 18 Aug 2010 23:33:37 -0700 (PDT), David Miller wrote:
> From: Hagen Paul Pfeifer <hagen@...u.net>
> Date: Sun, 15 Aug 2010 21:36:16 +0200
> 
>> +
>> +		if (sk->sk_userlocks & SOCK_RCVBUF_LOCK &&
>> +				(req->window_clamp > tcp_full_space(sk) || req->window_clamp ==
0))
>> +			req->window_clamp = tcp_full_space(sk);
>> +
> 
> Logically the patch looks fine, but please fix the indentation of the
> second line of the two new if() statements in this patch, the
> second line's first character should line up with the character
> right after the openning "(" on the previous line.

Sorry Dave, I played with my vim settings ... I will resubmit the patch.
;-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ