netdev - Re: [PATCH] net: use skb_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282658991.2477.233.camel@edumazet-laptop>
Date:	Tue, 24 Aug 2010 16:09:51 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: use skb_get_rxhash()

Le mardi 24 août 2010 à 21:53 +0800, Changli Gao a écrit :

> However, do we really need to check if skb->sk->sk_hash is zero? It is
> a rare case, and this check may mislead someone to think a non zero
> sk_hash means that sk_hash is set.
> 

Not sure what you mean ;)

sk_hash is not always filled, only for some kind of sockets (tcp, udp)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html