lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Aug 2010 22:35:35 +0800 From: Changli Gao <xiaosuo@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH] net: use skb_get_rxhash() On Tue, Aug 24, 2010 at 10:09 PM, Eric Dumazet <eric.dumazet@...il.com> wrote: > Le mardi 24 août 2010 à 21:53 +0800, Changli Gao a écrit : > >> However, do we really need to check if skb->sk->sk_hash is zero? It is >> a rare case, and this check may mislead someone to think a non zero >> sk_hash means that sk_hash is set. >> > > Not sure what you mean ;) > > sk_hash is not always filled, only for some kind of sockets (tcp, udp) > Hmm, if so, I think maybe addr_fold(skb->sk) is enough and more common. if (skb->sk) hash = addr_fold(skb->sk); else hash = skb->rxhash; /* saved addr_fold(skb->sk) by skb_orphan_try() previous */ -- Regards, Changli Gao(xiaosuo@...il.com) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists