netdev - Re: [IPoIB] Identify multicast packets and fix IGMP breakage V3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100826.170716.68143372.davem@davemloft.net>
Date:	Thu, 26 Aug 2010 17:07:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cl@...ux.com
Cc:	jgunthorpe@...idianresearch.com, rdreier@...co.com,
	linux-rdma@...r.kernel.org, ogerlitz@...taire.com,
	yosefe@...taire.com, netdev@...r.kernel.org
Subject: Re: [IPoIB] Identify multicast packets and fix IGMP breakage V3

From: Christoph Lameter <cl@...ux.com>
Date: Thu, 26 Aug 2010 18:57:09 -0500 (CDT)

> On Thu, 26 Aug 2010, Jason Gunthorpe wrote:
> 
>> I think doing the memcmp only in the multicast path should be
>> reasonable overhead wise.
> 
> Thats is not always possible. Here the multicast path is the
> default path that is taken 99% of the time.

The highest cost is bringing in that packet header's cache line, which
you've already done by reading the byte and checking for 0xff.

I doubt the memcmp() can possibly matter.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html