netdev - Re: [IPoIB] Identify multicast packets and fix IGMP breakage V3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100827001752.GB24333@obsidianresearch.com>
Date:	Thu, 26 Aug 2010 18:17:52 -0600
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Yossi Etigin <yosefe@...taire.com>
Cc:	Christoph Lameter <cl@...ux.com>, rdreier@...co.com,
	linux-rdma@...r.kernel.org, Or Gerlitz <ogerlitz@...taire.com>,
	netdev@...r.kernel.org
Subject: Re: [IPoIB] Identify multicast packets and fix IGMP breakage V3

On Fri, Aug 27, 2010 at 03:02:54AM +0300, Yossi Etigin wrote:

> Shouldn't struct ib_grh be packed to make this really work?

No idea what the kernel convention for this is. It looks OK to me, in
that no arch I am familiar with will insert padding.

> The code looks a little messy to me anyway... 
> How about using a local var which is a ptr to packed struct ib_grh? The
> compiler will probably eliminate it anyway.

This bike shed is looking pretty well painted already :)

Jason
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html