netdev - [RFC PATCH net-next-2.6] gro: drivers should feed GRO only with TCP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 01 Sep 2010 19:04:46 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: [RFC PATCH net-next-2.6] gro: drivers should feed GRO only with
 TCP packets

Many network devices can tell if an incoming frame is a TCP one for a
small cost.

Instead of feeding GRO with all packets, we could filter packets on this
information ?

This should help machines handling a mixed UDP/TCP workload, keeping gro
overhead as small as possible.

patch against tg3 as an example...

Alternative would be to set a bit "is_tcp" on napi_struct to let this
choice being done in network stack, not by each driver. 

Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
---
 drivers/net/tg3.c |   22 +++++++++++++++++-----
 1 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index bc3af78..d530a0a 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -4748,13 +4748,25 @@ static int tg3_rx(struct tg3_napi *tnapi, int budget)
 			}
 		}
 
+		/*
+		 * give to GRO stack only TCP frames, with good checksums.
+		 */
+		if ((desc->type_flags & RXD_FLAG_IS_TCP) &&
+		    skb->ip_summed == CHECKSUM_UNNECESSARY) {
 #if TG3_VLAN_TAG_USED
-		if (hw_vlan)
-			vlan_gro_receive(&tnapi->napi, tp->vlgrp, vtag, skb);
-		else
+			if (hw_vlan)
+				vlan_gro_receive(&tnapi->napi, tp->vlgrp, vtag, skb);
+			else
 #endif
-			napi_gro_receive(&tnapi->napi, skb);
-
+				napi_gro_receive(&tnapi->napi, skb);
+		} else {
+#if TG3_VLAN_TAG_USED
+			if (hw_vlan)
+				vlan_hwaccel_receive_skb(skb, tp->vlgrp, vtag);
+			else
+#endif
+				netif_receive_skb(skb);
+		}
 		received++;
 		budget--;
 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html