netdev - Re: [PATCH] net: arp: code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Sep 2010 09:28:13 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH] net: arp: code cleanup

On Thu, Sep 2, 2010 at 8:57 AM, David Miller <davem@...emloft.net> wrote:
>
> I do not condone comments being written this way, it wastes precious
> vertical space in one's terminal window.  They should always be
> written as:
>
>        /* A comment
>         * looks like this.
>         */

OK. Thanks.

>
>> @@ -258,31 +259,31 @@ static int arp_constructor(struct neighbour *neigh)
>>               neigh->output = neigh->ops->queue_xmit;
>>       } else {
>>               /* Good devices (checked by reading texts, but only Ethernet is
>> -                tested)
>> -
>> -                ARPHRD_ETHER: (ethernet, apfddi)
>  ...
>> -                in old paradigm.
>> +              * tested)
>> +              *
>> +              * ARPHRD_ETHER: (ethernet, apfddi)
>
> you go and apply COMPLETELY INCONSISTENT changes to other comemnts.
>
> Leave the comments alone, thanks.
>

Do you mean that all the multi-line comments should be written as you
said above or I should not touch any comment? Thanks.

-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html