netdev - Re: [PATCH] net: arp: code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100901.175712.199039832.davem@davemloft.net>
Date:	Wed, 01 Sep 2010 17:57:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiaosuo@...il.com
Cc:	kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH] net: arp: code cleanup

From: Changli Gao <xiaosuo@...il.com>
Date: Thu,  2 Sep 2010 07:51:50 +0800

> Clean the code up according to Documentation/CodingStyle.
> 
> Don't initialize the variable dont_send in arp_process().
> 
> Remove the temporary varialbe flags in arp_state_to_flags().
> 
> Replace printk(KERN_DEBUG...) with pr_debug(...).
> 
> Signed-off-by: Changli Gao <xiaosuo@...il.com>
> ---
>  1 file changed, 212 insertions(+), 228 deletions(-)
> diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
> index 96c1955..cbb0e7c 100644
> --- a/net/ipv4/arp.c
> +++ b/net/ipv4/arp.c
> @@ -1,4 +1,5 @@
> -/* linux/net/ipv4/arp.c
> +/*
> + * linux/net/ipv4/arp.c
>   *
>   * Copyright (C) 1994 by Florian  La Roche
>   *

I do not condone comments being written this way, it wastes precious
vertical space in one's terminal window.  They should always be
written as:

	/* A comment
	 * looks like this.
	 */

in any patch you want me to apply in the networking.

And what really angers me when people touch things like that is
how later in the patch:

> @@ -258,31 +259,31 @@ static int arp_constructor(struct neighbour *neigh)
>  		neigh->output = neigh->ops->queue_xmit;
>  	} else {
>  		/* Good devices (checked by reading texts, but only Ethernet is
> -		   tested)
> -
> -		   ARPHRD_ETHER: (ethernet, apfddi)
 ...
> -		   in old paradigm.
> +		 * tested)
> +		 *
> +		 * ARPHRD_ETHER: (ethernet, apfddi)

you go and apply COMPLETELY INCONSISTENT changes to other comemnts.

Leave the comments alone, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html