netdev - Re: [PATCH net-next-2.6] drivers/net : avoid some skb->ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100902.094135.112603353.davem@davemloft.net>
Date:	Thu, 02 Sep 2010 09:41:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] drivers/net : avoid some skb->ip_summed
 initializations

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 02 Sep 2010 18:25:46 +0200

> fresh skbs have ip_summed set to CHECKSUM_NONE (0)
> 
> We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.
> 
> Introduce skb_CHECKSUM_NONE_assert() helper so that we keep this
> assertion documented in driver sources.
> 
> Change most occurrences of :
> 
> skb->ip_summed = CHECKSUM_NONE;
> 
> by :
> 
> skb_CHECKSUM_NONE_assert(skb);
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Please, no capital letters in C function names.

I'll apply this with that fixed up.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html