netdev - Re: [PATCH net-next-2.6] drivers/net : avoid some skb->ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1283454780.3699.22.camel@edumazet-laptop>
Date:	Thu, 02 Sep 2010 21:13:00 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] drivers/net : avoid some skb->ip_summed
 initializations

Le jeudi 02 septembre 2010 à 09:41 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Thu, 02 Sep 2010 18:25:46 +0200
> 
> > fresh skbs have ip_summed set to CHECKSUM_NONE (0)
> > 
> > We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.
> > 
> > Introduce skb_CHECKSUM_NONE_assert() helper so that we keep this
> > assertion documented in driver sources.
> > 
> > Change most occurrences of :
> > 
> > skb->ip_summed = CHECKSUM_NONE;
> > 
> > by :
> > 
> > skb_CHECKSUM_NONE_assert(skb);
> > 
> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Please, no capital letters in C function names.
> 
> I'll apply this with that fixed up.
> 

Well, I wanted to keep the CHECKSUM_NONE "as is" to ease grep games.

Choices are :

1) put it in lower case : skb_checksum_none_assert()
2) Use a macro instead.
3) Other idea ?

(not sure if you already applied the patch or if you want a v2 from me)

Thanks !



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html