lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100906.130855.112605035.davem@davemloft.net> Date: Mon, 06 Sep 2010 13:08:55 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jirislaby@...il.com Cc: peppe.cavallaro@...com, netdev@...r.kernel.org Subject: Re: STMMAC: sleep inside atomic From: Jiri Slaby <jirislaby@...il.com> Date: Mon, 06 Sep 2010 21:25:07 +0200 > On 09/06/2010 11:47 AM, Peppe CAVALLARO wrote: >> On 9/4/2010 1:47 PM, Jiri Slaby wrote: >>> stanse found that the driver may sleep inside atomic: >>> stmmac_resume >>> -> spin_lock >>> -> stmmac_open >>> -> request_irq >>> -> kzalloc(..., GFP_KERNEL); >>> -> init_dma_desc_rings >>> -> kmalloc(..., GFP_KERNEL); >>> -> and many others... >>> -> spin_unlock >>> >>> Could you fix that? >>> >> Yes I could ... kmalloc(...,GFP_KERNEL) can sleep! >> I will fix the spinlock usage in the driver's resume function and send a >> patch to the mailing list asap. > > Hi, I hope you'll carbon-copy me. It's not only kmalloc, request_irq > and others may sleep too. Guiseppe CAVALLARO posted a patch that seems to be a working one, please see his netdev posting. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists