netdev - Re: [PATCH] stmmac: fix sleep inside atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100906.131107.183045782.davem@davemloft.net>
Date:	Mon, 06 Sep 2010 13:11:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] stmmac: fix sleep inside atomic

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Mon,  6 Sep 2010 05:06:19 +0200

> We cannot use spinlock when kmalloc is invoked with
> GFP_KERNEL flag because it can sleep.
> So this patch reviews the usage of spinlock within the
> stmmac_resume function avoing this bug.
> 
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

Applied, but you are extremely guilty of the sin of omission
here.

Why in the world did you not at least CC: Jiri, the person
who reported this problem?  You should do that at a minimum
when someone reports a problem with code you are fixing.

And in this case he definitely deserves a

Reported-by:

tag in the commit message as well.

Please don't fail to acknowledge a reporter's efforts like
this ever again.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html