netdev - Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <005f01cb533e$5c21d530$66f8800a@maildom.okisemi.com>
Date:	Mon, 13 Sep 2010 21:07:44 +0900
From:	"Masayuki Ohtake" <masa-korg@....okisemi.com>
To:	"Marc Kleine-Budde" <mkl@...gutronix.de>
Cc:	<meego-dev@...go.com>, "Wolfgang Grandegger" <wg@...ndegger.com>,
	<socketcan-core@...ts.berlios.de>, <netdev@...r.kernel.org>,
	<andrew.chih.howe.khor@...el.com>, <gregkh@...e.de>,
	<arjan@...ux.intel.com>, <qi.wang@...el.com>,
	<yong.y.wang@...el.com>, "Morinaga" <morinaga526@....okisemi.com>
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35

----- Original Message ----- 
From: "Marc Kleine-Budde" <mkl@...gutronix.de>
To: "Masayuki Ohtak" <masa-korg@....okisemi.com>
Cc: <meego-dev@...go.com>; "Wolfgang Grandegger" <wg@...ndegger.com>; <socketcan-core@...ts.berlios.de>;
<netdev@...r.kernel.org>; <andrew.chih.howe.khor@...el.com>; <gregkh@...e.de>; <arjan@...ux.intel.com>;
<qi.wang@...el.com>; <yong.y.wang@...el.com>
Sent: Wednesday, August 11, 2010 10:04 PM
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35


Hi Marc,

> - Try to send patches directly with git send-email
In our network environment, we can't use send-email.

> - don't use global variables
I have modified so that our patch doesn't use global variable except module parameter.

> - don't use that "int handle", e.g.:
I have deleted.


> - get rid of the intermediate struct pch_can_msg:
>   Your data path is:
>   struct can_frame -> struct pch_can_msg -> registers
>   write from struct can_frame into registers directly
Since Topcliff CAN HW register assign is different from struct can_frame,
I think intermediate structure is necessary.

> - what's the purpose of "p_can_os->can_callback", call the function
>   directly from the interrupt handler
I have deleted

> - implement NAPI
Since Topcliff CAN HW register has only single rx buffer,
I think NAPI is unnecessary.

> - get rid of "1 << BIT_SHIFT_SIX" and friend,
>   use "1 << 6" or "BIT(6)" if you like defines
I have modified.

> - use defines to set bits in struct can_frame can_id
I have modified.

I will resubmit modified our CAN patch soon.

Thanks, Ohtake(OKISemi)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html