netdev - Re: [PATCH] e1000e: Simplify MSI interrupt testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100913.201340.68129542.davem@davemloft.net>
Date:	Mon, 13 Sep 2010 20:13:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jdelvare@...e.de
Cc:	jeffrey.t.kirsher@...el.com, bruce.w.allan@...el.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] e1000e: Simplify MSI interrupt testing

From: Jean Delvare <jdelvare@...e.de>
Date: Mon, 13 Sep 2010 10:45:39 +0200

> The code is quite convoluted, simplify it. This also avoids calling
> e1000_request_irq() without testing the value it returned, which was
> bad.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Bruce Allan <bruce.w.allan@...el.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
> I understand that we need to request the IRQ again after testing, but
> why doing it twice?
> 
> I sent this patch to the e1000-devel list on August 26th, 2010, but
> didn't receive any answer:
> http://sourceforge.net/mailarchive/forum.php?thread_name=201008261445.44334.jdelvare%40suse.de&forum_name=e1000-devel

Intel folks, please provide feedback or else I'll just blindly apply Jean's
patch to the net-next-2.6 tree as long as it compiles ;-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html