netdev - Re: [PATCH 2/2] mac80211: fix compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100914060948.GA6908@ff.dom.local>
Date:	Tue, 14 Sep 2010 06:09:48 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Felipe Contreras <felipe.contreras@...il.com>,
	linux-kernel@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>,
	"John W. Linville" <linville@...driver.com>,
	"David S. Miller" <davem@...emloft.net>,
	Kalle Valo <kalle.valo@....fi>,
	Felix Fietkau <nbd@...nwrt.org>, Jouni Malinen <j@...fi>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] mac80211: fix compilation warning

On 2010-09-14 07:17, Johannes Berg wrote:
> On Sun, 2010-09-12 at 14:10 +0300, Felipe Contreras wrote:
> 
>>  	struct ieee80211_hdr hdr;
>> -	struct ieee80211s_hdr mesh_hdr;
>>  	const u8 *encaps_data;
>>  	int encaps_len, skip_header_bytes;
>>  	int nh_pos, h_pos;
>> @@ -1755,7 +1754,9 @@ netdev_tx_t ieee80211_subif_start_xmit(struct sk_buff *skb,
>>  		hdrlen = 30;
>>  		break;
>>  #ifdef CONFIG_MAC80211_MESH
>> -	case NL80211_IFTYPE_MESH_POINT:
>> +	case NL80211_IFTYPE_MESH_POINT: {
>> +		struct ieee80211s_hdr mesh_hdr;
>> +
> 
> ...
> 
> might be nicer to just add __maybe_unused.
> 
> johannes
> 

Or at least more consistent with the fix in net-next ;-)

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html