lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100914.134529.45905377.davem@davemloft.net> Date: Tue, 14 Sep 2010 13:45:29 -0700 (PDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: nicolas.dichtel@...nd.com, netdev@...r.kernel.org Subject: Re: [RFC PATCH] ipv4: release dev refcnt early when destroying inetdev From: Eric Dumazet <eric.dumazet@...il.com> Date: Fri, 10 Sep 2010 17:16:14 +0200 > Le vendredi 10 septembre 2010 à 16:57 +0200, Nicolas Dichtel a écrit : > >> Is this not true in IPv6? What is the difference? > > It might be a bug on ipv6, who knows ? > > Releasing a reference count, but not setting idev->dev to NULL is > a sign something is wrong... If anything this is more of a BUG trap than a true correctness patch, but either way if you want me to apply this please formally submit this with a proper commit message and signoff, thanks! > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 5bc893e..26e39bc 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -330,6 +330,7 @@ void in6_dev_finish_destroy(struct inet6_dev *idev) > printk(KERN_DEBUG "in6_dev_finish_destroy: %s\n", dev ? dev->name : "NIL"); > #endif > dev_put(dev); > + idev->dev = NULL; > if (!idev->dead) { > pr_warning("Freeing alive inet6 device %p\n", idev); > return; > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists