netdev - Re: [PATCH] 3c59x: Remove atomic context inside vortex_{set|get}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 Sep 2010 14:36:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dkirjanov@...nel.org
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com, ben@...adent.org.uk
Subject: Re: [PATCH] 3c59x: Remove atomic context inside
 vortex_{set|get}_wol

From: Denis Kirjanov <dkirjanov@...nel.org>
Date: Wed, 15 Sep 2010 14:58:46 +0400

> [PATCH v2] 3c59x: Remove atomic context inside vortex_{set|get}_wol
> 
> There is no need to use spinlocks in vortex_{set|get}_wol.
> This also fixes a bug:
...
> vortex_set_wol protected with a spinlock, but nested  acpi_set_WOL acquires a mutex inside atomic context.
> Ethtool operations are already serialized by RTNL mutex, so it is safe to drop the locks.
> 
> Signed-off-by: Denis Kirjanov <dkirjanov@...nel.org>
> ---
> V2: fixed comments issue

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html