netdev - Re: [PATCH net-next-2.6 2/2] ethtool: Remove unimplemented flow specification types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100915.144152.91337452.davem@davemloft.net>
Date:	Wed, 15 Sep 2010 14:41:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
	santwona.behera@....com, peter.p.waskiewicz.jr@...el.com
Subject: Re: [PATCH net-next-2.6 2/2] ethtool: Remove unimplemented flow
 specification types

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Tue, 14 Sep 2010 20:13:08 +0100

> struct ethtool_rawip4_spec and struct ethtool_ether_spec are neither
> commented nor used by any driver, so remove them.  Adjust padding in
> the user-visible unions that included these structures.
> 
> Fix references to struct ethtool_rawip4_spec in
> ethtool_get_rx_ntuple(), which should use struct ethtool_usrip4_spec.
> 
> struct ethtool_usrip4_spec cannot hold IPv6 host addresses and there
> is no separate structure that can, so remove ETH_RX_NFC_IP6 and the
> reference to it in niu.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Yeah.  The NIU chip's TCAM can only match on 32-bits (I think the
least significant) of the IPV6 address since that's how many bits
it has in the TCAM entries for addreses and address masks.

I'll apply this, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html