netdev - Re: [PATCH] ixgbe: add GRO to vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100914.213544.112598547.davem@davemloft.net>
Date:	Tue, 14 Sep 2010 21:35:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bphilips@...e.de
Cc:	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, alexander.h.duyck@...el.com,
	peter.p.waskiewicz.jr@...el.com, john.ronciak@...el.com,
	donald.c.skidmore@...el.com, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH] ixgbe: add GRO to vlan_features

From: Brandon Philips <bphilips@...e.de>
Date: Tue, 14 Sep 2010 18:50:53 -0700

> When running a vlan -> bridge -> domU setup I was noticing poor RX
> performance. It seems ixgbe and other drivers don't have NETIF_F_GRO set
> in vlan_features and thus GRO is off by default for vlans.
> 
> I see no reason why the other drivers shouldn't be fixed. If this is OK
> I will go off and fix the rest.
> 
> Signed-off-by: Brandon Philips <bphilips@...e.de>

I think it should be set, but why don't we do this another way?

This feature is a software feature, essentially, so if it is published
in netdev->features we can simply propagate it automatically to
netdev->vlan_features at device registry time in the core networking.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html