netdev - [PATCH] ixgbe: add GRO to vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100915015052.GA6602@mmm.home.ifup.org>
Date:	Tue, 14 Sep 2010 18:50:53 -0700
From:	Brandon Philips <bphilips@...e.de>
To:	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, alexander.h.duyck@...el.com,
	peter.p.waskiewicz.jr@...el.com, john.ronciak@...el.com,
	donald.c.skidmore@...el.com
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	e1000-devel@...ts.sourceforge.net
Subject: [PATCH] ixgbe: add GRO to vlan_features

When running a vlan -> bridge -> domU setup I was noticing poor RX
performance. It seems ixgbe and other drivers don't have NETIF_F_GRO set
in vlan_features and thus GRO is off by default for vlans.

I see no reason why the other drivers shouldn't be fixed. If this is OK
I will go off and fix the rest.

Signed-off-by: Brandon Philips <bphilips@...e.de>

---
 drivers/net/ixgbe/ixgbe_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index d03eef9..0b39757 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -6817,6 +6817,7 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
 	netdev->vlan_features |= NETIF_F_IP_CSUM;
 	netdev->vlan_features |= NETIF_F_IPV6_CSUM;
 	netdev->vlan_features |= NETIF_F_SG;
+	netdev->vlan_features |= NETIF_F_GRO;
 
 	if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)
 		adapter->flags &= ~(IXGBE_FLAG_RSS_ENABLED |
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html