netdev - Re: [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100916155745.GB14318@home.goodmis.org>
Date:	Thu, 16 Sep 2010 11:57:45 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Dan Rosenberg <drosenberg@...curity.com>
Cc:	j.dumon@...ion.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, security@...nel.org, davem@...emloft.net,
	stable@...nel.org
Subject: Re: [PATCH v2] drivers/net/usb/hso.c: prevent reading
 uninitialized memory

On Wed, Sep 15, 2010 at 05:43:28PM -0400, Dan Rosenberg wrote:
> Fixed formatting (tabs and line breaks).
> 
> The TIOCGICOUNT device ioctl allows unprivileged users to read
> uninitialized stack memory, because the "reserved" member of the
> serial_icounter_struct struct declared on the stack in hso_get_count()
> is not altered or zeroed before being copied back to the user.  This
> patch takes care of it.
> 
> Signed-off-by: Dan Rosenberg <dan.j.rosenberg@...il.com>
> 
> --- linux-2.6.35.4.orig/drivers/net/usb/hso.c	2010-08-26 19:47:12.000000000 -0400
> +++ linux-2.6.35.4/drivers/net/usb/hso.c	2010-09-14 21:26:18.477585183 -0400
> @@ -1653,6 +1653,8 @@ static int hso_get_count(struct hso_seri
>  	struct uart_icount cnow;
>  	struct hso_tiocmget  *tiocmget = serial->tiocmget;
>  
> +	memset(&icount, 0, sizeof(struct serial_icounter_struct));
> +

Move the above to after the spinlocks.

-- Steve

>  	if (!tiocmget)
>  		 return -ENOENT;
>  	spin_lock_irq(&serial->serial_lock);
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html