[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100916180710.07821bdd@lxorguk.ukuu.org.uk>
Date: Thu, 16 Sep 2010 18:07:10 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Dan Rosenberg <drosenberg@...curity.com>, j.dumon@...ion.com,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
security@...nel.org, davem@...emloft.net, stable@...nel.org
Subject: Re: [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized
memory
->tiocmget;
> >
> > + memset(&icount, 0, sizeof(struct serial_icounter_struct));
> > +
>
> Move the above to after the spinlocks.
Why - its a local variable ?
Easier to write
struct serial_icounter_struct icount = { 0 };
though
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists