netdev - Re: [PATCH] net/sched/sch_hfsc.c: initialize parent's cl_cfmin properly in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100917.164127.09754402.davem@davemloft.net>
Date:	Fri, 17 Sep 2010 16:41:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	soltys@....info, denys@...p.net.lb, netdev@...r.kernel.org
Subject: Re: [PATCH] net/sched/sch_hfsc.c: initialize parent's cl_cfmin
 properly in init_vf()

From: Patrick McHardy <kaber@...sh.net>
Date: Wed, 15 Sep 2010 19:54:49 +0200

> Am 01.09.2010 23:30, schrieb David Miller:
>> From: Michal Soltys <soltys@....info>
>> Date: Mon, 30 Aug 2010 23:34:10 +0200
>> 
>>> This patch fixes init_vf() function, so on each new backlog period parent's
>>> cl_cfmin is properly updated (including further propgation towards the root),
>>> even if the activated leaf has no upperlimit curve defined.
>>>
>>> Signed-off-by: Michal Soltys <soltys@....info>
>> 
>> Applied, thanks.
> 
> For the record, the patch seems fine to me. The root cause seems to be
> an optimization I introduced (pre-git, even history.git unfortunately)
> in vttree_get_minvt() that wasn't present in the original version:
> 
> static struct hfsc_class *
> vttree_get_minvt(struct hfsc_class *cl, u64 cur_time)
> {
>         /* if root-class's cfmin is bigger than cur_time nothing to do */
>         if (cl->cl_cfmin > cur_time)
>                 return NULL;

Actually, the HFSC scheduler was added with this test present.
The function had a different name, actlist_get_minvt(), at the
time.  See commit:

commit 6e22ce74ea0666a869ce82f418ce78b5be089fb4
Author: Patrick McHardy <kaber@...sh.net>
Date:   Wed Jan 28 20:15:03 2004 -0800

    [NET_SCHED]: Add HFSC packet scheduler.

in the history-2.6 GIT tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html