netdev - Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100917.164356.22528384.davem@davemloft.net>
Date:	Fri, 17 Sep 2010 16:43:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	bandan.das@...atus.com, bunk@...nel.org, eric.dumazet@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kaber@...sh.net
Subject: Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in
 ip_fragment

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 17 Sep 2010 14:51:17 +0800

> On Wed, Sep 15, 2010 at 01:32:09PM -0400, Bandan Das wrote:
>>
>> Sorry for the late response. Here's a patch that I put up based on Herbert's
>> suggestions. I ofcourse don't see the problem anymore after 
>> commit 87f94b4e91dc042620c527f3c30c37e5127ef757 but a generic helper such as this 
>> can be used anytime the bridge code is sending a packet over to the IP layer. 
>> Compile tested only but based on responses, will test it before submitting a 
>> final change. Also added it at two places where I know we do send a packet over to
>> the IP layer. I will add it at other places later as I come across them.
> 
> Looks fine to me.

Bandan, please submit this formally with proper commit message,
signoff, also the new function you added needs a minor coding
style fix, there needs to be a space after "if" and the openning
left parenthesis.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html