netdev - Re: [PATCH] net-2.6 be2net: fix to get RX IDs 0 and 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100916.215056.133407514.davem@davemloft.net>
Date:	Thu, 16 Sep 2010 21:50:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	somnath.kotur@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net-2.6 be2net: fix to get RX IDs 0 and 1

From: Somnath Kotur <somnath.kotur@...lex.com>
Date: Thu, 16 Sep 2010 17:09:02 +0530

> Change made to allocate RX IDs 0 and 1 for the two ports.
> To get RX Q IDs 0 and 1 enable RSS Capability for that interface.
> RX IDs 0 and 1 have 32 bit drop counters which will take a long time
> to wrap around thereby presenting a consistent stats display.
> 
> Signed-off-by: Somnath Kotur <somnath.kotur@...lex.com>

I don't understand this commit message at all.

The patch looks like it's simply respecting capability flags
stored in the chip, and thus will now enable RSS on more
interfaces than it did before.

And that has absolutely nothing to do with allocating specific
RX IDs or anything like that.

It also, therefore, has nothing to do with fixing any kind of
serious regression in this driver.  Therefore this patch is
absolutely not appropriate for net-2.6

Please give a more accurate and understandable commit message
for this patch, and target it for net-next-2.6 unless you can
show that this fixes a very serious bug in 2.6.36
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html