netdev - Re: [PATCH v2] drivers/net/tulip/de4x5.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100916.215313.180410528.davem@davemloft.net>
Date:	Thu, 16 Sep 2010 21:53:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	drosenberg@...curity.com
Cc:	grundler@...isc-linux.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, kyle@...artin.ca, jeffm@...e.com,
	security@...nel.org
Subject: Re: [PATCH v2] drivers/net/tulip/de4x5.c

From: Dan Rosenberg <drosenberg@...curity.com>
Date: Wed, 15 Sep 2010 17:43:18 -0400

> Fixed formatting (tabs and line breaks).
> 
> This was previously reported as a security issue due to leakage of
> uninitialized stack memory.  Jeff Mahoney pointed out that this is
> incorrect since the copied data is from a union (rather than a struct).
> Therefore, this patch is only under consideration for the sake of
> correctness, and is not security relevant. 
> 
> Signed-off-by: Dan Rosenberg <dan.j.rosenberg@...il.com>
> Acked-by: Grant Grundler <grundler@...isc-linux.org>

You need to give something more descriptive than just the name of the
file you're editing in the Subject: line of this commit message.

Otherwise people scanning "shortlog" and similar output won't have
even a general idea of what kind of change your commit is making.

Please formally resubmit this with a proper commit header line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html