netdev - Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100921.145703.189694076.davem@davemloft.net>
Date:	Tue, 21 Sep 2010 14:57:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues
 once we know the correct value

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 20 Sep 2010 20:05:46 +0100

> If RPS is enabled there's a separate kobject for each RX queue.  Those
> other drivers probably should be setting it.
> 
> Oh, but this only exists if CONFIG_RPS is enabled.  I think we need an
> inline function for setting this.

It's set in the core by alloc_netdev_mq(), you should never have to
set this in your driver.

And that also takes care of the CONFIG_RPS dependency in one spot,
another good argument for drivers never touching this value.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html