netdev - Re: [PATCH v2] net: af_packet: don't call tpacket_destruct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimK7iAHBZ4ZFRf11b4z86m8SfhbELwMurNgDVw9@mail.gmail.com>
Date:	Wed, 22 Sep 2010 17:24:16 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	mst@...hat.com, eric.dumazet@...il.com, socketcan@...tkopp.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: af_packet: don't call tpacket_destruct_skb()
 until the skb is sent out

On Wed, Sep 15, 2010 at 11:20 AM, David Miller <davem@...emloft.net> wrote:
>
>
> Changli, I have one other minor request, please name this something
> like "shinfo->data_destructor" and "shinfo->data_destructor_arg".
>
> I think that will make it easier for other humans to understand :)
>

OK. Thanks.

But there is another issue, when splice() is involved. If we splice
the skbs generated by AF_PACKET socket to a pipe, the fragment pages
will be hold by the pipe, but the skbs are freed, and AF_PACKET socket
will been told that the corresponding TX ring buffers are available
for the other uses wrongly.

-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html