netdev - Re: [PATCH v2] net: af_packet: don't call tpacket_destruct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=iYahjwZt5w53xFsU7fyHr72wXHd9tycwUiNE9@mail.gmail.com>
Date:	Wed, 22 Sep 2010 17:35:07 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	David Miller <davem@...emloft.net>, eric.dumazet@...il.com,
	socketcan@...tkopp.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: af_packet: don't call tpacket_destruct_skb()
 until the skb is sent out

On Wed, Sep 15, 2010 at 1:23 PM, Michael S. Tsirkin <mst@...hat.com> wrote:
>
> Hmm, and there's another issue I think I see here:
> destructor_arg now points to a socket.
> What happens if the skb gets queued on an interface for a very long time
> (as can be the case with e.g. tap), and meanwhile
> you try to kill the task that owns the socket, which
> will try to destroy the socket?
>
> Original code handles this by relevant devices orphaning an skb
> if it's queued indefinitely.
>

I don't think the skb_orphan() there is used to destroy the socket in
time, but notify the socket that skbs are sent out and it can send new
skbs.

-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html