netdev - Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1285169327.2279.3.camel@achroite.uk.solarflarecom.com>
Date:	Wed, 22 Sep 2010 16:28:47 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues
 once we know the correct value

On Tue, 2010-09-21 at 18:38 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Wed, 22 Sep 2010 02:31:36 +0100
> 
> > Right, but we do need to have some way for drivers to specify the actual
> > number of RX queues.
> 
> Ok, the problem stems merely from the fact that we only specify one
> "queue count" in alloc_netdev_mq().  We should specify two, one for
> TX and one for RX.
> 
> So why not fix that instead of putting hacks into the drivers? :-)

That still doesn't solve the original problem, since drivers generally
won't know how many RX queues they should (or can) create until some
time after calling alloc_netdev_mq().

You know very well why we distinguish real_num_tx_queues and
num_tx_queues; what's so different about RX queues?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html