netdev - Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1285170286.2639.428.camel@edumazet-laptop>
Date:	Wed, 22 Sep 2010 17:44:46 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues
 once we know the correct value

Le mercredi 22 septembre 2010 à 16:28 +0100, Ben Hutchings a écrit :

> 
> That still doesn't solve the original problem, since drivers generally
> won't know how many RX queues they should (or can) create until some
> time after calling alloc_netdev_mq().
> 
> You know very well why we distinguish real_num_tx_queues and
> num_tx_queues; what's so different about RX queues?

rx queues were added by Tom for RPS.
No function prototypes were changed to provide it as a new parameter.

What we need is to extend alloc_netdev_mq() to take a new rx_queue_count
parameter.

Then allow these txq/rxq parameters to be "unset for the moment", and
provide a new function to allocate / populate queues when driver knows
what to do, _after_ its alloc_netdev_mq() call.

Your one line patch is a work around, not a clean solution.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html