netdev - Re: [PATCH 1/2 -next] r8169: allocate with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100924131842.26f1fb1f@dhcp-lab-109.englab.brq.redhat.com>
Date:	Fri, 24 Sep 2010 13:18:42 +0200
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when
 able to sleep

On Thu, 23 Sep 2010 23:20:12 +0200
Francois Romieu <romieu@...zoreil.com> wrote:

> Stanislaw Gruszka <sgruszka@...hat.com> :
> > We have fedora bug report where driver fail to initialize after
> > suspend/resume because of memory allocation errors:
> > https://bugzilla.redhat.com/show_bug.cgi?id=629158
> > 
> > To fix use GFP_KERNEL allocation where possible. 
> 
> Feel free to add a Acked-by: Francois Romieu <romieu@...zoreil.com>
> as soon as it will have been explicitely reported to improve the
> situation (it is not clear in the PR above).

I'm pretty sure patch fix the problem, however yes, we do not have
confirmation from reporter yet. Anyway atomic allocation should not
be used in process context.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html