netdev - Re: [PATCH 1/2 -next] r8169: allocate with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100924222434.GA7743@electric-eye.fr.zoreil.com>
Date:	Sat, 25 Sep 2010 00:24:34 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when able
 to sleep

Stanislaw Gruszka <sgruszka@...hat.com> :
> Francois Romieu <romieu@...zoreil.com> wrote:
[...]
> > Feel free to add a Acked-by: Francois Romieu <romieu@...zoreil.com>
> > as soon as it will have been explicitely reported to improve the
> > situation (it is not clear in the PR above).
> 
> I'm pretty sure patch fix the problem, however yes, we do not have
> confirmation from reporter yet.

A success report would help me swallow a 6 parameters
rtl8169_alloc_rx_skb method.

The driver is not smart wrt partially allocated rx ring, especially
at init time. It considers a single init time skb allocation failure
fatal.

> Anyway atomic allocation should not be used in process context.

What do you mean ? tg3->open() does not seem to bother. It is not alone.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html