lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100924.223709.233700415.davem@davemloft.net> Date: Fri, 24 Sep 2010 22:37:09 -0700 (PDT) From: David Miller <davem@...emloft.net> To: romieu@...zoreil.com Cc: sgruszka@...hat.com, netdev@...r.kernel.org Subject: Re: [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when able to sleep From: Francois Romieu <romieu@...zoreil.com> Date: Sat, 25 Sep 2010 00:24:34 +0200 > Stanislaw Gruszka <sgruszka@...hat.com> : >> Francois Romieu <romieu@...zoreil.com> wrote: > [...] >> Anyway atomic allocation should not be used in process context. > > What do you mean ? tg3->open() does not seem to bother. It is not alone. I think this is merely an indication that r8169 is more often used in systems that actually suspend/resume than tg3 is. tg3 ought to be doing this too for correctness, as should pretty much every network driver. Stanislaw's patches are very reasonable, especially if the problem is happening. But yes a "Tested-by: " confirming the fix would really be appeciated before we apply this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists