lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1285394797.2478.54.camel@edumazet-laptop> Date: Sat, 25 Sep 2010 08:06:37 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: David Miller <davem@...emloft.net> Cc: romieu@...zoreil.com, sgruszka@...hat.com, netdev@...r.kernel.org Subject: Re: [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when able to sleep Le vendredi 24 septembre 2010 à 22:37 -0700, David Miller a écrit : > From: Francois Romieu <romieu@...zoreil.com> > Date: Sat, 25 Sep 2010 00:24:34 +0200 > > > Stanislaw Gruszka <sgruszka@...hat.com> : > >> Francois Romieu <romieu@...zoreil.com> wrote: > > [...] > >> Anyway atomic allocation should not be used in process context. > > > > What do you mean ? tg3->open() does not seem to bother. It is not alone. > > I think this is merely an indication that r8169 is more often > used in systems that actually suspend/resume than tg3 is. tg3 > ought to be doing this too for correctness, as should pretty much > every network driver. > Sure but most people use MTU=1500, so tg3 works well. Only r8169 allocates high order pages even with normal MTU > Stanislaw's patches are very reasonable, especially if the problem > is happening. > > But yes a "Tested-by: " confirming the fix would really be > appeciated before we apply this. > -- Patch solves the suspend/resume, probably, but as soon as we receive trafic, we can hit the allocation error anyway... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists