netdev - Re: [PATCH net-next-2.6] rps: allocate rx queues in register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100926.190509.258105871.davem@davemloft.net>
Date:	Sun, 26 Sep 2010 19:05:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com, therbert@...gle.com
Subject: Re: [PATCH net-next-2.6] rps: allocate rx queues in
 register_netdevice only

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 24 Sep 2010 05:26:35 +0200

> [PATCH net-next-2.6] rps: allocate rx queues in register_netdevice()
> 
> Instead of having two places were we allocate dev->_rx, introduce
> netif_alloc_rx_queues() helper and call it only from
> register_netdevice(), not from alloc_netdev_mq()
> 
> Goal is to let drivers change dev->num_rx_queues after allocating netdev
> and before registering it.
> 
> This also removes a lot of ifdefs in net/core/dev.c
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks Eric.

Please cook up a patch that adds a check to make sure that
alloc_netdev_mq() is never called with number of queues < 1

Thanks again!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html