netdev - Re: [PATCH net-next-2.6] net: fix rcu use in ip_route_output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100926.190531.233710747.davem@davemloft.net>
Date:	Sun, 26 Sep 2010 19:05:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	paulmck@...ux.vnet.ibm.com, akpm@...ux-foundation.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net: fix rcu use in ip_route_output_slow

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 24 Sep 2010 09:46:03 +0200

> [PATCH net-next-2.6] net: fix rcu use in ip_route_output_slow
> 
> __in_dev_get_rtnl(dev_out) is called while RTNL is not held, thus
> triggers a lockdep fault.
> 
> At this point, we only perform a raw test of dev_out->ip_ptr being NULL,
> we dont need to make sure ip_ptr cant changed right after.
> 
> We can use rcu_dereference_raw() for this.
> 
> Reported-by: Andrew Morton <akpm@...ux-foundation.org>
> Acked-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html