netdev - Re: [PATCH] ip_gre: CONFIG_IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100928.214132.226782961.davem@davemloft.net>
Date:	Tue, 28 Sep 2010 21:41:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH] ip_gre: CONFIG_IPV6_MODULE support

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 29 Sep 2010 13:36:42 +0900

> On Wed, Sep 29, 2010 at 06:24:55AM +0200, Eric Dumazet wrote:
>>
>> Well, we all know icmpv6_cleanup() is not really called (or can we
>> really unload ipv6 ?).
>> 
>> But unregister_icmpv6_send() should be the first call in it.
> 
> Do we really need to support IPV6=m and GRE=y? It might be simpler
> to just behave as if IPv6 is off when this combination is given.

I think we should make it so that the Kconfig rule only allows
"m" or "n" for IP_GRE when IPV6=m

That's how we handle this kind of situation elsewhere, f.e. see
bonding.

Eric, please cook up a patch which does this, I think the
magic Kconfig dependency formula for this is:

	depends on IPV6 || IPV6=n

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html