lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100928.222510.71109554.davem@davemloft.net> Date: Tue, 28 Sep 2010 22:25:10 -0700 (PDT) From: David Miller <davem@...emloft.net> To: gwurster@....carleton.ca Cc: kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net, shemminger@...tta.com, eric.dumazet@...il.com, herbert@...dor.apana.org.au, ebiederm@...ssion.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH linux-2.6 v2] IPv6: Create temporary address if none exists. From: Glenn Wurster <gwurster@....carleton.ca> Date: Mon, 27 Sep 2010 13:04:30 -0400 > If privacy extentions are enabled, but no current temporary address exists, > then create one when we get a router advertisement. > > Version 2, now with 100% fewer line wraps. Thanks to David Miller for > pointing out the line wrapping issue. > > Signed-off-by: Glenn Wurster <gwurster@....carleton.ca> The existing code is correct from what I can tell. Variable "create" is true when "ifp == NULL" and "valid_lft != 0" And RFC 3041 explicitly states in section 3.3: When a new public address is created as described in [ADDRCONF] (because the prefix advertised does not match the prefix of any address already assigned to the interface, and Valid Lifetime in the option is not zero), also create a new temporary address. Your patch is going to cause us to create a temporary address even when valid_lft is zero, which the RFC says we should not do. That goes against what the RFC tells us to do, so I can only conclude that your patch is not correct. I'm not applying this, sorry. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists